Merge Click and Typer functionality#1680
Merged
svlandeg merged 6 commits intofastapi:drop-clickfrom Apr 13, 2026
Merged
Conversation
9 tasks
svlandeg
changed the title
LVT-ENG
approved these changes
Apr 8, 2026
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tiangolo
approved these changes
Apr 11, 2026
Member
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Awesome! This is looking great. I really like the approach of only carefully moving things around so that we can have a huge but mostly harmless PR / release, and then we'll be able to start trimming things out. 🚀
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue work from #1525 and #1601, vendoring Click.
Note: this PR is best reviewed commit-by-commit. I've intentionally created the commits to be self-contained and tests should pass (excl coverage) after each commit. I've refrained from doing additional unnecessary edits/cleanup so that the diff would be minimal in this PR.
At several places in Typer's codebase, we override/subclass Click's behaviour. This PR simplifies the code in these cases, as we don't need to keep legacy Click code around anymore.
0% vibe-coded, 100% manually-executed refactor to (try and) ensure high quality & reduce unexpected errors.
This PR
Pathfunctionality from Typer & ClickArgumentfunctionality from Typer & ClickOptionfunctionality from Typer & ClickchainfromTyperOptionandTyperArgumentGroupfunctionality from Typer & ClickChoicefunctionality from Typer & Click_click.shell_completionandtyper._completion_classesFollow-up work
Coverage stats
This branch, before this PR:
This branch, after this PR: